Conversation
olevski
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
note that
env::set_varandenv::remove_varareunsafein rust 2024, not because of Rust, but because the underlying Posix implementation is unsafe (so it's already unsafe in rust 2021, just not marked as such).The whole code for setting log env var is weird anyways, since we already used
env_loggerwhich has config for setting the log level. I've switched to using that and also using clap-verbosity-flag which is purpose built by the clap devs for handling-vin conjuction withenv_logger.renamed
gentogeneratorsincegenis now a reserved keyword (forgen fniterator functions, like python iterator functions withyield).I also fixed the one warning that clippy spits out, maybe we should not deny warnings in
renku-cli/flake.nix
Line 113 in 6d9fac2